IBX-10370: Added Tab Tables possible extension point to use in another bundles #1706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ezrobot
requested review from
Steveb-p,
adamwojs,
alongosz,
barw4,
ciastektk,
konradoboza,
mikadamczyk,
tbialcz and
wiewiurdp
and removed request for
a team
adamwojs
reviewed
Oct 13, 2025
|
|
||
| namespace Ibexa\AdminUi\Tab\Event; | ||
|
|
||
| class CollectCustomTableColumnsEvent |
There was a problem hiding this comment.
- Good practice is that event classes extends
\Symfony\Contracts\EventDispatcher\Event - Is it intentionally open for inheritance ?
| use Twig\Extension\AbstractExtension; | ||
| use Twig\TwigFunction; | ||
|
|
||
| final class TableExtension extends AbstractExtension |
wiewiurdp
approved these changes
Oct 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
Description:
I decided to not use those two function inside base adminUI template to not progate this extension point in 4.6 as we may decide to move into table objects at some point.
It also is very tricky do to it in base, when table body is used else where, as there is no access to data row object anymore at admin-ui level.
For QA:
Documentation: